Debucquoy Anthony tonitch
1 Followers · 1 Following
Repositories
26
 Projects Packages Public Activity Starred Repositories
4
tonitch pushed to erb_messaging at PGL/Clyde 2023-12-13 22:57:59 +01:00
d4e3ded3da Rework
9c1103ab59 First ERB messaging
Compare 2 commits »
tonitch commented on pull request PGL/Clyde#14 2023-12-13 22:46:12 +01:00
First ERB messaging
tonitch pushed to erb_messaging at PGL/Clyde 2023-12-13 22:45:38 +01:00
2522cef18a Update 'Documents/proto/messaging_extension/ERD.md'
tonitch pushed to erb_messaging at PGL/Clyde 2023-12-13 22:31:51 +01:00
733cfb90d5 Update 'Documents/proto/messaging_extension/ERD.md'
tonitch deleted branch Ext_publiScientifique from PGL/Clyde 2023-12-13 17:00:12 +01:00
tonitch deleted branch GestionHoraire from PGL/Clyde 2023-12-13 16:59:38 +01:00
tonitch commented on pull request PGL/Clyde#12 2023-12-13 16:30:08 +01:00
Adding role to users

@PGL/Owners je viens de régler les conflits, pouvez vous review plz ? :))

tonitch pushed to api-user-role at PGL/Clyde 2023-12-13 16:28:04 +01:00
e6e498d36f Merge branch 'master' into api-user-role
351c0dbfb2 Merge pull request 'Ext_publiScientifique' (#5) from Ext_publiScientifique into master
3e304ca0ac Merge branch 'master' into Ext_publiScientifique
9e299b39bd Merge pull request 'GestionHoraire' (#6) from GestionHoraire into master
c807568689 Dispay-Article -> DisplayArticle
Compare 15 commits »
tonitch pushed to class_messaging at PGL/Clyde 2023-12-13 16:20:21 +01:00
2698ca580b Merge branch 'master' into class_messaging
351c0dbfb2 Merge pull request 'Ext_publiScientifique' (#5) from Ext_publiScientifique into master
3e304ca0ac Merge branch 'master' into Ext_publiScientifique
9e299b39bd Merge pull request 'GestionHoraire' (#6) from GestionHoraire into master
c807568689 Dispay-Article -> DisplayArticle
Compare 15 commits »
tonitch pushed to erb_messaging at PGL/Clyde 2023-12-13 16:20:00 +01:00
6c451867b3 Merge branch 'master' into erb_messaging
351c0dbfb2 Merge pull request 'Ext_publiScientifique' (#5) from Ext_publiScientifique into master
3e304ca0ac Merge branch 'master' into Ext_publiScientifique
9e299b39bd Merge pull request 'GestionHoraire' (#6) from GestionHoraire into master
c807568689 Dispay-Article -> DisplayArticle
Compare 15 commits »
tonitch created pull request PGL/Clyde#14 2023-12-13 16:18:31 +01:00
First ERB messaging
tonitch pushed to erb_messaging at PGL/Clyde 2023-12-13 16:18:08 +01:00
19cfa31bf3 First ERB messaging
tonitch pushed to erb_messaging at PGL/Clyde 2023-12-13 16:17:14 +01:00
db08522941 First ERB messaging
tonitch created branch erb_messaging in PGL/Clyde 2023-12-13 16:17:14 +01:00
tonitch approved PGL/Clyde#6 2023-12-13 14:59:51 +01:00
GestionHoraire
tonitch approved PGL/Clyde#5 2023-12-12 22:59:15 +01:00
Ext_publiScientifique

lgtm

tonitch commented on pull request PGL/Clyde#5 2023-12-12 22:58:51 +01:00
Ext_publiScientifique

c'est pas très grave mais ça me parait weird d'avoir un endpoint avec un tired. j'utiliserait personnelment du PascalCase /DisplayArticle ou camelCase /displayArticle

tonitch commented on pull request PGL/Clyde#4 2023-12-12 22:54:45 +01:00
salutcesmoileo

pour le patch ça pose pas de problème mais pour le post tu ne peux pas demander d'envoyer un id car il n'y a pas encore d'id.

tonitch commented on pull request PGL/Clyde#4 2023-12-12 22:47:33 +01:00
salutcesmoileo

je ne sais pas si c'est l'intention, mais tu n'as pas la possibilité de faire un fetch de toutes les requests.

tonitch commented on pull request PGL/Clyde#4 2023-12-12 22:47:33 +01:00
salutcesmoileo

si tu appliques les précédents commentaire tu as soit le choix de laisser le post dans /Requests/{type} soit de le mettre avec /Requests et dans ce cas il suffit de mettre le type en paramètre dans requestBody ou dans query (je pense que requestBody serait mieux dans le cas présent)